Skip to content

Nitpicks for TwitchClient.cs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmitch0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Nitpicks for TwitchClient.cs #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions Assets/Scripts/TwitchClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void Start()
Application.runInBackground = true;

//set up bot and tell what channel to join
ConnectionCredentials credentials = new ConnectionCredentials("simpagamebot", Secrets.bot_access_token);
ConnectionCredentials credentials = new ConnectionCredentials(bot_name, Secrets.bot_access_token);
client = new Client();
client.Initialize(credentials, channel_name);
//pubSub = new PubSub();
Expand Down Expand Up @@ -103,41 +103,34 @@ private string ConvertWhisperToCommand(string whisper)
{
return whisper;
}
else
{

whisper = whisper.Substring(1);
string[] commandArray = whisper.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
return (commandArray[0].ToLower());

}
whisper = whisper.Substring(1);
string[] commandArray = whisper.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
return (commandArray[0].ToLower());
}

private string ConvertWhisperToArguments(string whisper)
{
string commands = "";
if (string.IsNullOrEmpty(whisper))
{
return whisper;
}
else
{

whisper = whisper.Substring(1);
string[] commandArray = whisper.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
Debug.Log(commandArray[0]);
if (commandArray.Length > 1)
{
for (int i = 1; i < commandArray.Length; i++)
{
commands += commandArray[i];
}
}
commands = commands.ToLower();
return (commands);

string commands = "";
whisper = whisper.Substring(1);
string[] commandArray = whisper.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
Debug.Log(commandArray[0]);
for (int i = 1; i < commandArray.Length; i++)
{
// nit: building a string by adding them together in a for loop is inefficient
// It's probably not a problem in this case, but a better solution is to use String.Join
// https://docs.microsoft.com/en-us/dotnet/api/system.string.join?view=net-5.0
commands += commandArray[i];
}
commands = commands.ToLower();
return (commands);
}

private List<string> ParseCommand(string command)
{
List<string> list = new List<string>();
Expand Down