Updated/added license headers of all files according to new configura…#84
Open
RadekKoubsky wants to merge 1 commit intoSilverThings:develfrom
Open
Updated/added license headers of all files according to new configura…#84RadekKoubsky wants to merge 1 commit intoSilverThings:develfrom
RadekKoubsky wants to merge 1 commit intoSilverThings:develfrom
Conversation
RadekKoubsky
force-pushed
the
license-maven-plugin-update
branch
from
548b971 to
c4b2ad7
Compare
RadekKoubsky
force-pushed
the
license-maven-plugin-update
branch
from
c4b2ad7 to
dc3b4b7
Compare
…tion of license-maven-plugin.
RadekKoubsky
force-pushed
the
license-maven-plugin-update
branch
from
dc3b4b7 to
60ea60b
Compare
Member
|
The headers were intentional because the plugin did not recognize the headers properly without them. |
Member
|
They were there to fix a problem. So unless you figure out what problem it was and come up with a solution that fixes both issues, we cannot merge this, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion of license-maven-plugin.
See issue #80
I have changed the configuration of license-maven-plugin:
<failOnMissingHeader>true</failOnMissingHeader>I removed all license headers and add new license headers according to the new configuration using goal
mvn license:update-file-headerto make all headers consistent.Building script contains goal
license:check-file-header -Dlicense.licenseName=apache_v2to check missing headers before build.