This repository was archived by the owner on May 30, 2024. It is now read-only.
Open
Conversation
gmcgibbon
force-pushed
the
run_migration
branch
2 times, most recently
from
1072615 to
dd67c96
Compare
Adds code lens to run migrations to specific versions in the terminal. This is convenient because it allows developers to quickly rollback or fast-forward to specific schema versions with a click.
gmcgibbon
force-pushed
the
run_migration
branch
from
dd67c96 to
4656838
Compare
Contributor
|
This pull request is being marked as stale because there was no activity in the last 2 months |
Contributor
|
(we'll need to move this over to the monorepo) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds code lens to run migrations to specific versions in the terminal. This is convenient because it allows developers to quickly rollback or fast-forward to specific schema versions with a click.
Part of Shopify/ruby-lsp-rails#239
Implementation
Followed the example of the test running controller and test command registration.
Automated Tests
I don't see any tests for the test command, do they exist? Happy to add tests if I have an example to follow.
Manual Tests
Build the extension, install the extension on a Rails app with Ruby LSP + Rails extension setup using Shopify/ruby-lsp-rails#239. Then, navigate to a migration to observe the added code lens.