Skip to content

Conversation

@kiftio
Copy link
Contributor

@kiftio kiftio commented Dec 23, 2025

What changes are you making?

Optional change, opening for awareness of the inconsistency.

    @discardableResult public func onFail(_ action: @escaping (CheckoutError) -> Void) -> Self {
        delegate.onFail = action
        return self
    }
    override fun onFail(error: CheckoutException) {

I tested by adding in a throw when opening the sheets from the native side, and seeing that they propagate to the react native handler in the js debugger:

ios

image

android
image

PR Checklist

Important

Releasing a new version of the kit?


Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@kiftio kiftio requested a review from a team as a code owner December 23, 2025 14:40
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Coverage Report

Lines Statements Branches Functions
Coverage: 83%
82.91% (233/281) 83.33% (110/132) 83.33% (65/78)

@kieran-osgood-shopify kieran-osgood-shopify self-assigned this Jan 5, 2026
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the prototype-development/onerror-to-onfail branch from e6c0819 to e494c32 Compare January 5, 2026 13:56
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the prototype-development/onerror-to-onfail branch from e494c32 to a106f3f Compare January 5, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants