Skip to content

ensure options.modalProduct.styles get passed through to view when options.product.styles is false #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tessalt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ensure options.modalProduct.styles get passed through to view when options.product.styles is false #824

tessalt wants to merge 1 commit into from

Conversation

@tessalt
Copy link
Contributor

@tessalt tessalt commented Aug 25, 2022

Fixes a bug where if options.modalProduct.styles is configured but options.product.styles is not set, the modalProduct styles are disregarded.

@tessalt
Copy link
Contributor Author

tessalt commented Aug 30, 2022

I've signed the CLA but the job needs to be re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tessalt