WIP precompile task for firefox #112
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bassam Mansoob <bassam.mansoob@shopify.com>
profiler_backend is now private, and can only be read and updated through: - AppProfiler.backend= - AppProfiler.backend A new helper method AppProfiler.with_backend is used to wrap singular access to the backend.
Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
…t reference to self
Callers should now either use VernierProfile or StackprofProfile to get an explicit base class. If loading from the eigenclass, they should use AbstractProfile.from_stackprof or AbstractProfile.from_vernier instead of Profile.from_X.
This reverts commit d7940d3.
…ated AppProfiler.viewer
dalehamel
force-pushed
the
firefox-viewer
branch
from
fe924ec to
5bf3609
Compare
dalehamel
force-pushed
the
firefox-viewer
branch
from
0d06e94 to
c7cfd20
Compare
gmcgibbon
force-pushed
the
firefox-viewer
branch
from
7b22aa1 to
148aa55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for fetching firefox profiler from a pre-compiled bundle.
By default, also adds support for fetching from GCS behind auth using gcloud token.
Adds rake tasks as helpers to compile and package the bundle.