Add default message if none provided#10
Open
justinbeaty wants to merge 1 commit intoShogunPanda:mainfrom
Open
Conversation
Author
|
@mgcrea is this what you envisioned? |
955ae1e to
980888c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7
Currently if you create an error and don't provide a message, it will be an empty string. This PR makes it so the default message is used from
messagesByCodes[].Examples:
Also added a
message !== nullcheck sincetypeof null === 'object'and it would throw if you callednew UnauthorizedError(null). Not sure why someone would do that, but just for extra safety.