Refactor search type logic and implement reusable SearchTypeFilter component

[Ziedelth]

• Unified search type handling with SearchableController abstraction.
• Added reusable SearchTypeFilter widget to simplify UI and improve consistency.
• Replaced query string concatenation with a typed map in HttpRequest.
• Updated multiple controllers and views to utilize the new search logic and component.

[gemini-code-assist]

Summary of Changes

Hello @Ziedelth, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's search type filtering mechanism. It introduces a unified approach for managing search types across various data controllers and provides a reusable UI component for consistency. Additionally, it enhances the robustness of HTTP requests by transitioning from manual query string building to a more structured map-based parameter handling, making the codebase cleaner and more maintainable.

Highlights

• Unified Search Type Handling: Introduced a SearchableController interface and moved the SearchType enum to its own file, standardizing how search types are managed across different controllers.
• Reusable Search Type Filter Component: Created a new SearchTypeFilter widget that encapsulates the UI and logic for selecting search types, replacing duplicated code in AdvancedCalendar and AdvancedSearchCard.
• Refactored HTTP Request Query Parameters: Updated the HttpRequest utility to accept query parameters as a typed map instead of raw string concatenation, improving readability and safety for API calls.
• Controller and UI Integration: Multiple controllers (AnimeController, AnimeSearchController, AnimeWeeklyController, etc.) and UI components (AdvancedCalendar, AdvancedSearchCard, SimulcastDropdownButton) have been updated to utilize the new SearchableController interface, SearchTypeFilter widget, and the improved HttpRequest query handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This is an excellent refactoring that greatly improves the codebase. The introduction of the SearchableController abstraction and the reusable SearchTypeFilter widget effectively centralizes the search type logic and removes a significant amount of duplicated code from the UI components. The move to a typed map for query parameters in HttpRequest is another major improvement, making the API calls cleaner, safer, and more maintainable across all controllers.

My review includes a few suggestions to further enhance the robustness of the HTTP requests and improve code style and maintainability. Overall, great work on this pull request!