Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Scala 2.13 cross build take 2#28

Open
reinierl wants to merge 4 commits intomasterfrom
scala-2.13
Open

Scala 2.13 cross build take 2#28
reinierl wants to merge 4 commits intomasterfrom
scala-2.13

Conversation

@reinierl
Copy link

@reinierl reinierl commented Oct 3, 2019

No description provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https


addSbtPlugin("com.newmotion" % "sbt-build-seed" % "4.1.2")
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.1.1")
addSbtPlugin("com.newmotion" % "sbt-build-seed" % "5.0.4")
Copy link

@kiequoo kiequoo Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you aware that 5.0.4 only cross-builds Scala 2.12 and 2.13 by default? I think in this case as this library only uses akka and akka still supports 2.11 we can probably cross build to all 3 versions still

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was aware of the former but not giving much of a thought to 2.11 support. I'll try to add it back.

@kiequoo
Copy link

kiequoo commented Oct 3, 2019

Should update the .travis.yml file to support 2.13 too (and newer version of 2.12)

Copy link

@kiequoo kiequoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments