Skip to content

Conversation

@BrainBacon
Copy link
Contributor

This change makes it so you can refer to CPU helper functions as you would normally from a standard rust module.

e.g.

my_shader_module::on_cpu::my_helper()

becomes

my_shader_module::my_helper()

There are still some oddities, namely that currently user types are reexported by the parser instead of marking them pub like one would normally do in a standard rust module. I may address this in a future patch.

@Sheldonfrith
Copy link
Owner

Yeah, I suppose putting that stuff under the namespace on_cpu mainly just made sense to me because they had to be generated slightly differently in the proc macro, but no need to expose those implementation details to the user, just adds confusion, so I'm fine with this change.

@Sheldonfrith Sheldonfrith merged commit 19d62dd into Sheldonfrith:main Feb 7, 2025
9 checks passed
@BrainBacon BrainBacon deleted the feature/module-visibility branch February 16, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants