12 refactor and cleanup proc macro crate #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commit, and checking that consts work on CPU side functions
Owner
Author
|
Didn't realize I'd have to pay for getting GPU access on my github actions runners... so going to remove the example from the CI test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code in the proc macro crate has actually NOT been changed, but ALL of the files have been moved around, so if you were working on something in the proc macro crate you will have to find out where the logic you were working on has been moved to. That shouldn't be too hard as the crate is now much more organized and easy to understand. Also made some other small changes like adding the example to the CI script as an extra safety measure.