Skip to content

Conversation

@DavidMarcial
Copy link
Contributor

This action will convert a catalog list collector variable into an array.

@github-actions
Copy link

Valid PR for ActionPack

Thank you for your contribution. This PR complies with the CONTRIBUTING.md.
A maintainer will review this shortly. In the meantime, Happy Hacking!

@rohi-v rohi-v self-assigned this Oct 31, 2025
@rohi-v
Copy link
Contributor

rohi-v commented Oct 31, 2025

Looks Good, Thank you for your contribution

@rohi-v rohi-v merged commit 148c8e7 into ServiceNowDevProgram:main Oct 31, 2025
2 checks passed
rohi-v added a commit that referenced this pull request Oct 31, 2025
@rohi-v
Copy link
Contributor

rohi-v commented Oct 31, 2025

I just noticed few points, If you could re-update the action and submit another PR It would be good.

  1. Make Input mandatory
  2. Make Input type as list collector and not string.

@DavidMarcial
Copy link
Contributor Author

@rohi-v I agree with making the input mandatory. When you ask me to change the type, I don't have any such option to add that type. A catalog list collector variable is a string, or am I mistaken?
image

@rohi-v
Copy link
Contributor

rohi-v commented Oct 31, 2025

@rohi-v I agree with making the input mandatory. When you ask me to change the type, I don't have any such option to add that type. A catalog list collector variable is a string, or am I mistaken? image

Yeahh My bad, Please make input mandatory.

@DavidMarcial
Copy link
Contributor Author

@rohi-v No worries. I updated the action and did another pull request.

@rohi-v
Copy link
Contributor

rohi-v commented Oct 31, 2025

Version 2 - #256 closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants