Skip to content

Disable image signing for PR workflows #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarvAmBass merged 1 commit into from
Dec 10, 2025
Merged

Disable image signing for PR workflows #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
cache-to: type=gha,mode=max

- name: Sign the published Docker image
if: ${{ steps.docker_version_check.outputs.tag == 'true' }}
if: ${{ (steps.docker_version_check.outputs.tag == 'true') && (github.event_name != 'pull_request') }}
run: echo "${{ steps.meta.outputs.tags }}" | xargs -I {} cosign sign --yes {}@${{ steps.build-and-push.outputs.digest }}


Expand All @@ -122,7 +122,7 @@ jobs:
cache-to: type=gha,mode=max

- name: Sign the published Docker image - smbd-only
if: ${{ steps.docker_version_check.outputs.tag == 'true' }}
if: ${{ (steps.docker_version_check.outputs.tag == 'true') && (github.event_name != 'pull_request') }}
run: echo "${{ steps.meta.outputs.tags }}" | xargs -I {} cosign sign --yes {}@${{ steps.build-and-push-smbd-only.outputs.digest }}


Expand All @@ -140,7 +140,7 @@ jobs:
cache-to: type=gha,mode=max

- name: Sign the published Docker image - smbd-avahi
if: ${{ steps.docker_version_check.outputs.tag == 'true' }}
if: ${{ (steps.docker_version_check.outputs.tag == 'true') && (github.event_name != 'pull_request') }}
run: echo "${{ steps.meta.outputs.tags }}" | xargs -I {} cosign sign --yes {}@${{ steps.build-and-push-smbd-avahi.outputs.digest }}


Expand All @@ -158,5 +158,5 @@ jobs:
cache-to: type=gha,mode=max

- name: Sign the published Docker image - smbd-wsdd2
if: ${{ steps.docker_version_check.outputs.tag == 'true' }}
if: ${{ (steps.docker_version_check.outputs.tag == 'true') && (github.event_name != 'pull_request') }}
run: echo "${{ steps.meta.outputs.tags }}" | xargs -I {} cosign sign --yes {}@${{ steps.build-and-push-smbd-wsdd2.outputs.digest }}