Fix for Unions, Padding, x86/x64, some .NET versions sanity check in tests#42
Open
Technus wants to merge 7 commits intoSergeyTeplyakov:masterfrom
Open
Fix for Unions, Padding, x86/x64, some .NET versions sanity check in tests#42Technus wants to merge 7 commits intoSergeyTeplyakov:masterfrom
Technus wants to merge 7 commits intoSergeyTeplyakov:masterfrom
Conversation
Owner
|
Tha change looks very promissing. Thanks a lot! |
Author
|
Also enforced Padder to insert padding even for empty/not full classes/structs. |
Technus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed null checks to pattern matching to avoid ==/!= overloads.
Added testing for more .NET platforms.
Fixed failing test was MASTER_STRUCTFieldsRecursive by:
Added Declaring class Sorting.
Added Interleaved Padding support.
TODO:
Needs check if behavioir is repeatable on x86/x64 - added tests as it might change the alignment layout. (Count of paddings might change) - Added tests
Also it seems that the struct packing behavioir changes based on .NET version. (So counts of paddings may vary) - Added tests to .net framework and core
Added some support for Inline Arrays (.Net 8) and tests
AFAIK This will not make the code output invalid values for fields but hardcoded test assertions might make the tests fail.