Skip to content

Comments

Small Changes :3#261

Open
Serial-V wants to merge 3 commits intoSerenityJS:mainfrom
Serial-V:main
Open

Small Changes :3#261
Serial-V wants to merge 3 commits intoSerenityJS:mainfrom
Serial-V:main

Conversation

@Serial-V
Copy link
Contributor

  • Small entity filtering to check if the entity identifier exists in the world's entity palette, if not well skips it.
    • This just to avoid runtime crashes
    • This can be better but simple for now
  • Added Facing param for the /summon command, allows operators to summon a entity and makes the entity face towards the player.
    • This could be improved in the future?

Copy link
Member

@PMK744 PMK744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create the changes listed

const spawnedEntity = entity.spawn();

// Wait 2 seconds before setting the rotation to allow the entity to spawn
setTimeout(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using setTimeout isn't really the approach we want, we need to adjust the entity's rotation based on the given position rather than fetching the movement trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants