Refactor plugin config and file system handling#180
Open
Nathan93705 wants to merge 6 commits intoSerenityJS:mainfrom
Open
Refactor plugin config and file system handling#180Nathan93705 wants to merge 6 commits intoSerenityJS:mainfrom
Nathan93705 wants to merge 6 commits intoSerenityJS:mainfrom
Conversation
Introduces PluginConfig and PluginFileSystem classes for managing plugin configuration and file operations. Refactors Pipeline and Plugin to use these abstractions, removing legacy config and file methods from Plugin. Adds config/configParser.ts, config/pluginConfig.ts, and fileSystem.ts for modular configuration and file system logic.
Ensures non-string arguments are returned as-is in the logger, preventing unintended formatting and improving type safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces PluginConfig and PluginFileSystem classes for managing plugin configuration and file operations. Refactors Pipeline and Plugin to use these abstractions, removing legacy config and file methods from Plugin. Adds config/configParser.ts, config/pluginConfig.ts, and fileSystem.ts for modular configuration and file system logic.