Prevent duplicate submissions in the NewsletterSignUpForm component #3062
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontend once a submission is completed
🧪 CI InsightsHere's what we observed from your CI run for 2297662. 🟢 All jobs passed!But CI Insights is watching 👀 |
yitzhakc
reviewed
Feb 1, 2026
| if (showNameInputs === true) { // submit | ||
| if (firstName.length > 0 && lastName.length > 0) { | ||
| setSubscribeMessage("Subscribing..."); | ||
| subscribe(firstName, lastName, email, educatorCheck, additionalNewsletterMailingLists).then(res => { |
Contributor
There was a problem hiding this comment.
Since this is the call to the API, do you perhaps want to disable the button prior to the call, as soon as the user has Clicked, and keep it disabled until the request returns - either as a 200 success, or a failure? This way, the button will be clickable until the request returns..
Contributor
Author
There was a problem hiding this comment.
Yep, that would be better to handle that scenario too. I'll implement it. I forgot to consider that. Thanks
…ontend during the submission process while the API call is being made
…e state variables
…submit button when the form is not submitting or already subscribed
relyks
force-pushed
the
feature/sc-41273/prevent-duplicate-submissions-in-the
branch
from
91c13d5 to
2297662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once the NewsletterSignUpForm is populated with the submitter's information and the submission completes successfully, the submitter should be prevented from submitting again. Doing so will prevent duplicate submissions from being entered into Salesforce and ActiveCampaign
Code Changes