fix: Pass active_module to template context for favicon rendering #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The favicon links in base.html use {{ active_module }} to construct
paths like /static/icons/{{ active_module }}/favicon.ico. However,
render_template() was not passing active_module to the template context,
causing the favicon path to be incomplete on pages using this function.
This resulted in bookmarks of the homepage showing a default globe icon
instead of the Sefaria samech favicon.
https://claude.ai/code/session_01B8CFbT8vgvTWyjXAHrpDRp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The favicon links in base.html use {{ active_module }} to construct paths like /static/icons/{{ active_module }}/favicon.ico. However, render_template() was not passing active_module to the template context, causing the favicon path to be incomplete on pages using this function.
This resulted in bookmarks of the homepage showing a default globe icon instead of the Sefaria samech favicon.
https://claude.ai/code/session_01B8CFbT8vgvTWyjXAHrpDRp
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here