chore(client): replace jQuery DOM ready with vanilla JavaScript #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes jQuery dependency from client.jsx by replacing: - jQuery DOM ready callback with DOMContentLoaded event listener - $(window).width() with window.innerWidth This modernizes the code and reduces the dependency footprint. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🧪 CI InsightsHere's what we observed from your CI run for 7b1e62e. 🟢 All jobs passed!But CI Insights is watching 👀 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the client initialization code by removing the jQuery dependency and replacing it with vanilla JavaScript equivalents. This is part of a technical cleanup effort to reduce unnecessary dependencies in the application.
Changes:
- Removed jQuery import from
client.jsxsince it's no longer directly used in this file - Replaced jQuery DOM ready callback with native
DOMContentLoadedevent listener - Replaced jQuery's
$(window).width()with nativewindow.innerWidthfor viewport width detection
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
client.jsx$(function() {...})withdocument.addEventListener('DOMContentLoaded', ...)$(window).width()withwindow.innerWidthContext
Resolves technical cleanup issue SC-998: "Why is client.jsx main method being called through jQuery?"
The entire client.jsx was wrapped in a jQuery DOM ready callback, which was unnecessary overhead. This change modernizes the code to use vanilla JavaScript equivalents.
Test plan
npm run build🤖 Generated with Claude Code