Open
Conversation
jsoref
commented
Jan 27, 2019
| SQLiteDatabase db = dbHandler.getWritableDatabase(); | ||
| db.execSQL("DROP TABLE IF EXISTS " + TABLE_HEADERS); //TODO be able to update only a bit at a time. | ||
| db.execSQL(CREATE_HEADES_TABLE); | ||
| db.execSQL(CREATE_HEADES_TABLE /* headers? heads? */); |
Author
There was a problem hiding this comment.
it should be headers, but it requires a change to Sefaria-SQL (API)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this is a fairly large PR, it's split by word family which is my default.
I've tried to exclude translation fixes in general (I have a branch called "ignore" which has some of those at the top).
There are some exceptions.
But, in general, the categories of fixes are:
In some cases, I've inserted
??because the item doesn't make sense and I'm not sure what the correct text is.I'm happy to split this up however requested (within limits, 40+PRs would be a bit much, but 5 PRs with some direction is manageable).