Bug: Fix red ImGui error window in combobox. Fix Duplicate case insensitive paths on Windows. Fix Nullptr deref. #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug with dropdown when there is an empty string.
Sebanisu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with dropdown when there is an empty string.
Issue was because I was calling an early return instead of continue when the string was empty. This is for skipping known empty items or items that don't do anything in the field map editor.
Also fixed duplicate paths on Windows because of case insensitivity.
Found nullptr deref. I added some detection for the remaster and I forgot to check to see if m_field was null before going into it. I just was testing adding a path by browsing and it crashed.