Skip to content

chore(build): using vite#39

Open
axel7083 wants to merge 4 commits intoSdju:masterfrom
axel7083:chore/using-vite-build
Open

chore(build): using vite#39
axel7083 wants to merge 4 commits intoSdju:masterfrom
axel7083:chore/using-vite-build

Conversation

@axel7083
Copy link
Contributor

@axel7083 axel7083 commented Mar 4, 2025

Description

This PR change the build logic to vite.

I noticed that I was not able to build properly the library, as the package.json use the lib/index.js as entry

js-ini/package.json

Lines 5 to 6 in e5c1868

"main": "lib/index.js",
"types": "lib/index.d.ts",

But when running npm build we are output to the dist folder

"build": "tsc -p ./tsconfig.min.json && esbuild \"./dist/index.js\" --minify --outfile=\"dist/index.min.js\"",

Notes

Running npm install force the package-lock.json to be updated to the latest version

axel7083 added 3 commits March 4, 2025 15:08
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 marked this pull request as draft March 4, 2025 14:40
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 marked this pull request as ready for review March 4, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant