Add .zarr file loading for faster upfront training#24
Open
StewartSethA wants to merge 112 commits intoScrollPrize:mainfrom
Open
Add .zarr file loading for faster upfront training#24StewartSethA wants to merge 112 commits intoScrollPrize:mainfrom
StewartSethA wants to merge 112 commits intoScrollPrize:mainfrom
Conversation
… from original code
November updates for Vesuvius-c
Update README.md
vesuvius-c fix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
Thank you Seth for your PR After looking over the scroll2zarr adjustments, i have some questions:
|
Comment on lines
+500
to
+502
| if err is not None: | ||
| print("error returned:", err) | ||
| return 1 |
Contributor
There was a problem hiding this comment.
There appears to be a logic error in the zarr_only branch. The function unconditionally returns 1 (error code) regardless of whether tifs2zarr() succeeds or fails. This should be modified to return 0 when err is None and 1 when an error occurs. Consider updating the code to:
if zarr_only:
print("zarr_only tifs2zarr", tiffdir, zarrdir, chunk_size, slices, maxgb)
err = tifs2zarr(tiffdir, zarrdir, chunk_size, slices=slices, maxgb=maxgb)
if err is not None:
print("error returned:", err)
return 1
return 0 # Success case
Suggested change
| if err is not None: | |
| print("error returned:", err) | |
| return 1 | |
| if err is not None: | |
| print("error returned:", err) | |
| return 1 | |
| return 0 # Success case |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
bruniss
added a commit
that referenced
this pull request
Sep 8, 2025
Remove `assert()` from `local_cost*` methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new segment_to_ome.py utility based on existing scroll_to_ome.py for converting segments into .zarr format for faster loading, and an implementation of .zarr array loading in one of the training scripts