Add help text for edge-app run --secret and apply Clippy fixes #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation for the `--secret` option in the `screenly edge-app run` command to clarify its usage (expects KEY=VALUE pairs and can be specified multiple times). Also renames a test function in `edge_app/utils.rs` for clarity.
sergey-borovkov
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing help documentation for the
--secretoption in thescreenly edge-app runcommand. This clarifies that the option expects secrets inKEY=VALUEformat and can be used multiple times.Additionally, this PR includes:
test_transform_edge_app_path_to_manifest_when_path_provided_should_return_path_with_manifest) insrc/commands/edge_app/utils.rsfor better clarity.src/commands/edge_app/setting.rsandsrc/commands/serde_utils.rs.Cargo.lock.All tests pass and Clippy checks are clean after these changes.