Fix Getting Started post-completion navigation: focus last editor or open Untitled#5
Open
lordspline wants to merge 1 commit intomainfrom
Open
Fix Getting Started post-completion navigation: focus last editor or open Untitled#5lordspline wants to merge 1 commit intomainfrom
lordspline wants to merge 1 commit intomainfrom
Conversation
…pen Untitled if none to avoid unexpected redirects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Ensure closing the Getting Started page returns users to a real editor.\n- If an editor exists, we leave focus on the last active editor; if none remain, we open a new Untitled file to provide a stable landing.\n- Prevents unexpected redirects (e.g., Marketplace) after onboarding.\n\nNotes\n- Minimal change in StartupPageRunnerContribution: on closing Getting Started, schedule a fallback that opens an Untitled file only when no editors are open.\n- Pseudo-telemetry comment documents the path taken.\n\nManual test\n- Start with empty window. Open Getting Started. Complete or close it.\n- Expected: focus is on an existing editor if present; otherwise a new Untitled file is opened and the editor area is focused.\n- No auto-navigation to Marketplace unless explicitly invoked by the user.
₍ᐢ•(ܫ)•ᐢ₎ Generated by Scout (view jam)