-
Notifications
You must be signed in to change notification settings - Fork 106
intellij-jbr25*: Add version 25-b176.4
#577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
intellij-jbr25*: Add version 25-b176.4
#577
Conversation
WalkthroughAdds four new Scoop manifest files for JetBrains Runtime 25 variants (base, SDK, JCEF, SDK+JCEF) for Windows x64 and arm64, including metadata, per-arch download URLs and SHA-512 checksums, extract directories, environment variables (JAVA_HOME, PATH), PowerShell checkver scripts parsing GitHub release tags, and autoupdate rules. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. intellij-jbr25-jcef
intellij-jbr25-sdk-jcef
intellij-jbr25-sdk
intellij-jbr25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
bucket/intellij-jbr25-jcef.jsonbucket/intellij-jbr25-sdk-jcef.jsonbucket/intellij-jbr25-sdk.jsonbucket/intellij-jbr25.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: WindowsPowerShell
- GitHub Check: PullRequestHandler
🔇 Additional comments (8)
bucket/intellij-jbr25-sdk.json (2)
22-43: Well-designed version checking logic.The checkver script correctly handles version detection with a two-stage approach: the script pattern (line 29) captures numeric values for proper integer sorting, while the final regex (line 41) preserves the full "b176" format needed for version strings and URLs. The fallback mechanism on line 28 is a good safeguard.
8-15: The manifest structure and hash format are correct; direct URL/checksum verification requires external network access.The manifest is valid JSON with properly formatted SHA-512 hashes (128 hex characters each). The structure is consistent with existing JBR manifests (jbr21, jbr17, jbr11). The autoupdate mechanism correctly references external checksum files via
.checksumURLs, delegating validation to the published sources. Note: jbr25 only includes 64bit and arm64 architectures, unlike jbr21 which includes 32bit. The license field uses "GPL-2.0-only" (differs from previous versions using "GPL-2.0").bucket/intellij-jbr25.json (2)
22-43: Well-designed version checking logic.The checkver implementation is consistent across all JBR 25 variants and correctly handles version parsing and sorting.
8-15: Incorrect file references for JBR 25-b176.4 Windows builds.Windows distributions for JBR 25-b176.4 are only available as
jbr_jcefvariants (with JCEF bundled), not as vanilla base JBR. The correct filenames should referencejbr_jcef-25-windows-x64-b176.4andjbr_jcef-25-windows-aarch64-b176.4, not plainjbr-25-windows-*files. Update the URLs and comment accordingly, or clarify whether the intent was to reference a different JBR variant or platform.Likely an incorrect or invalid review comment.
bucket/intellij-jbr25-jcef.json (2)
22-43: Consistent version checking implementation.The checkver logic is properly implemented and consistent with the other JBR 25 variants.
8-15: All download URLs for the JCEF variant are accessible and the SHA-512 checksums are correct for both architectures (x64 and aarch64).bucket/intellij-jbr25-sdk-jcef.json (2)
22-43: Consistent version checking implementation.The checkver logic is properly implemented and consistent across all four JBR 25 variant manifests.
8-15: SDK+JCEF variant URLs are accessible and correctly configured.Both JBR SDK+JCEF download URLs for Windows x64 and aarch64 architectures are accessible. The SHA-512 checksums are provided in the correct format and the extract directory names match their corresponding archive filenames.
Update the descriptions to match upstream.
intellij-jbr25*: Add version 25b176.4intellij-jbr25*: Add version 25-b176.4
Closes #576
intellij-jbr25*: JetBrains Runtime is a fork of OpenJDK available for Windows, Mac OS X, and Linux. It supports enhanced class redefinition (DCEVM), features optional JCEF, a framework for embedding Chromium-based browsers, includes a number of improvements in font rendering, keyboards support, windowing/focus subsystems, HiDPI, accessibility, and performance, provides better desktop integration and bugfixes not yet present in OpenJDK.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.