Do not allow anymore to create Variables or Attributes with an empty name#53
Merged
jeandet merged 1 commit intoSciQLop:mainfrom Feb 18, 2026
Merged
Conversation
…name. While technically legal (no mention in the official format doc), others CDF implementations consider the file corrupted if a name is empty. Fixes SciQLop#48
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 88.27% 88.18% -0.09%
==========================================
Files 56 56
Lines 3198 3209 +11
==========================================
+ Hits 2823 2830 +7
- Misses 375 379 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces input validation to ensure that variable and attribute names cannot be empty throughout the CDF library, improving data integrity and preventing subtle bugs. It also adds corresponding Python unit tests to verify these constraints. Additionally, the pull request includes a minor improvement to the variable output streaming function.
Input validation improvements:
Variable,Attribute, andVariableAttribute(invariable.hppandattribute.hpp) to throw an exception if the name is empty, enforcing that all variable and attribute names must be non-empty. [1] [2] [3] [4]Testing enhancements:
PycdfEmptyNamesAreNotAllowedintest.py) that verifies an exception is raised when attempting to create variables or attributes with empty names, ensuring the new validation logic is covered.Code maintainability:
operator<<forcdf_map<std::string, cdf::Variable>incdf-file.hppby usingstd::for_eachfor cleaner and more modern iteration over variables.Closes #48