Conversation
devmotion
reviewed
Sep 10, 2025
Comment on lines
12
to
13
| randexp(rng::PassthroughRNG) = Random.randexp() | ||
| randn(rng::PassthroughRNG) = Random.randn() |
Member
There was a problem hiding this comment.
Since they are not imported, I assume one needs
Suggested change
| randexp(rng::PassthroughRNG) = Random.randexp() | |
| randn(rng::PassthroughRNG) = Random.randn() | |
| Random.randexp(rng::PassthroughRNG) = Random.randexp() | |
| Random.randn(rng::PassthroughRNG) = Random.randn() |
(and the line above which I can't comment on) since otherwise calls of randexp etc. below for other RNGs than PassthroughRNG will fail.
Member
Author
There was a problem hiding this comment.
Maybe these should just be internal wrappers with a slightly different name? Like _rand, _randexp, etc? That would make clear these aren't meant to be public dispatches of Random.rand and such?
Member
There was a problem hiding this comment.
IMO the simplest would be to just define Random.rand, Random.randexp, and Random.randn for PassthroughRNG. For all other RNGs, the code will work automatically, without having to go through some internal function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if tests pass, but I don't see why these are even necessary.