gpu support for pois_rand#54
Merged
ChrisRackauckas merged 12 commits intoSciML:masterfrom Aug 6, 2025
Merged
Conversation
sivasathyaseeelan
changed the title
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
Member
|
The prod version works with GPU? If so then this looks good to me. |
Member
|
note that this code still could use significant removal of Float64 hard coding. |
Member
|
Yes, for another time. |
isaacsas
reviewed
Sep 10, 2025
| randexp(rng::PassthroughRNG) = Random.randexp() | ||
| randn(rng::PassthroughRNG) = Random.randn() | ||
|
|
||
| rand(rng::AbstractRNG) = Random.rand(rng) |
Member
There was a problem hiding this comment.
@ChrisRackauckas aren't these three here pirating from base?
Member
There was a problem hiding this comment.
oh wait there is a direct using. ehhh
Member
There was a problem hiding this comment.
we should probably delete the last of these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #51
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.