Fix ModelingToolkit minimum version bound #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ModelingToolkit v8 from compat since the codebase uses v9-only features: - `t_nounits` and `D_nounits` (introduced in v9) These are used in lecture1.jl, lecture2.jl, and run_away_train_hydraulic.jl. The docs/Project.toml already correctly requires v9 only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
The main Project.toml had
ModelingToolkit = "8, 9"in the compat section, but the lecture files use features that are only available in ModelingToolkit v9+:t_nounitsandD_nounits- These were introduced in v9 as part of the units refactoringAffected files that use v9-specific features:
docs/src/lectures/lecture1.jldocs/src/lectures/lecture2.jldocs/src/lectures/run_away_train_hydraulic.jlNote: The
docs/Project.tomlalready correctly specifiesModelingToolkit = "9".Test Plan
t_nounitsandD_nounitscc @ChrisRackauckas
🤖 Generated with Claude Code