-
Notifications
You must be signed in to change notification settings - Fork 4
Template GMGPolar class on DomainGeometry #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 88.21% 88.15% -0.07%
==========================================
Files 89 92 +3
Lines 5246 5249 +3
==========================================
- Hits 4628 4627 -1
- Misses 618 622 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6dbfd1f to
ae1aee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The executables
src/convergence_order.cpp
src/weak_scaling.cpp
src/strong_scaling.cpp
are now broken, since they are not yet adjusted to the new interface.
Let me know if we want to fix this with this PR or deal with it in the future.
The interface will change again with the next upcoming changes, so it is likely not worth the effort to do this now.
As per #131 inheritance must be removed from kernels in order to port them to GPU. Concepts are used as a drop-in replacement for superclasses to enforce prototypes. This work is started with
DomainGeometry's use inGMGPolar.Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):