Update Claude Code settings schema with missing settings and fixes #5300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 10 missing settings: language, autoUpdatesChannel, attribution, fileSuggestion, terminalProgressBarEnabled, showTurnDuration, plansDirectory, respectGitignore, allowManagedHooksOnly, strictKnownMarketplaces - Fix documentation URL (docs.claude.com → code.claude.com) - Mark includeCoAuthoredBy as DEPRECATED per SchemaStore guidelines - Fix permission rule pattern: remove undocumented BashOutput/SlashCommand - Add documentation links and default values throughout - Update test file with coverage for new settings Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Thanks for the PR! This section of the codebase is owned by @domdomegg and @bogini - if they write a comment saying "LGTM" then it will be merged. |
for more information, see https://pre-commit.ci
These hooks are functional but not yet in official documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…settings Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
domdomegg
reviewed
Jan 22, 2026
domdomegg
suggested changes
Jan 22, 2026
Contributor
domdomegg
left a comment
domdomegg
left a comment
There was a problem hiding this comment.
Per comment, otherwise looks good and can get this merged!
Contributor
|
Is this ready to be merged? |
Contributor
Author
|
@domdomegg Thanks for the review. @madskristensen I'll make the small change Adam's asked for. Then, it'll be merge ready. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
@madskristensen Ready now |
Contributor
|
LGTM |
Contributor
|
Merging because @domdomegg is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
language,autoUpdatesChannel,attribution,fileSuggestion,terminalProgressBarEnabled,showTurnDuration,plansDirectory,respectGitignore,allowManagedHooksOnly,strictKnownMarketplacesdocs.claude.com→code.claude.com)includeCoAuthoredByasDEPRECATED.per SchemaStore guidelinesBashOutput/SlashCommandtoolsTest plan
node ./cli.js check --schema-name=claude-code-settings.json- all validations passsrc/test/claude-code-settings/modern-complete-config.jsonwith new settings🤖 Generated with Claude Code