Compliance by Scetrov · Pull Request #19 · Scetrov/void-eid

Scetrov · 2026-02-13T21:31:54Z

1. Title

feat: implement user profile deletion and compliance updates

2. Description

What?

This PR introduces the ability for users to delete their profiles, adds essential legal documentation (Privacy Policy, Terms of Service, etc.), and updates the codebase to use more inclusive language ("denylist" instead of "blacklist").

Why?

Compliance: To adhere to data privacy regulations (GDPR/CCPA), users must have a way to delete their accounts and be informed of their rights through legal documentation.
Inclusivity: Standardizing inclusive language across the project.
Security: Ensuring that deleted users' identifiers (Discord ID, Wallets) are denylisted (hashed) to prevent re-registration or misuse of deleted accounts.

How?

Backend:
- Implemented delete_profile endpoint in auth.rs.
- Added hashing logic to safely store denylisted identifiers.
- Updated database schemas and queries to use denylisted terminology.
Frontend:
- Added ConfirmationModal for critical actions like account deletion.
- Implemented deleted.tsx route for the post-deletion state.
- Added static markdown files for legal policies and a generic $page.tsx route to render them.
- Updated DashboardLayout and AuthProvider to handle the new routes and states.

3. Type of Change

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, etc.)
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing tests or correcting existing tests
chore: Changes to the build process or auxiliary tools and libraries

4. Development Checklist

Rust: Ran cargo fmt and cargo clippy.
TypeScript: Ran bun run lint in the frontend directory.
Migrations: If the database schema was modified, ran sqlx migrate run and updated sqlx-data.json via cargo sqlx prepare.
Testing: Verified changes locally with appropriate tests.
Release: Confirmed that any necessary version metadata patching is compatible with the automated release workflow.

5. Security Assessment

Evaluating against OWASP Top 10:2025 guidelines.

Access Control: Verified that AuthenticatedUser extractors properly validate session state and that deletion is restricted to the owner.
Injection: Verified that all new SQLx queries use parameterized inputs for denylist checks.
Cryptographic: Implemented salted hashing for denylisted identifiers to ensure privacy while maintaining security.
CORS/Infrastructure: No changes to infrastructure or overly permissive policies.

OWASP Mapping	MITRE ATT&CK ID	Impact Description
A01:2025	T1078	Verified session boundaries for profile deletion.
A03:2025	T1059	Used parameterized SQLx queries.

6. Frontend (if applicable)

Components adhere to the "Design System".
Screenshots or screen recordings of the UI changes are attached below. (To be added manually).

7. Reviewer Feedback & Resolution

This PR follows the "Fix & Reply" loop for all unresolved comments.

I have replied directly to all reviewer comment threads with a resolution summary.
All fixes are committed atomically with references to the specific feedback.

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…ncies

…n in OpenAPI paths

…-system mismatch

Scetrov · 2026-02-13T22:45:47Z

I have addressed the second round of review comments.

Key changes:

Enforced IDENTITY_HASH_PEPPER to prevent insecure fallbacks.
Fixed a potential SQLite deadlock by moving log_audit after transaction commit.
Expanded account deletion scrubbing to include user_tribes, mumble_accounts, and notes.
Improved ConfirmationModal accessibility (ARIA roles, keyboard support) and user flow (redirecting to /deleted).

Verified with pre-commit run --all. Commit: 5730d5e

Copilot

Pull request overview

Copilot reviewed 24 out of 28 changed files in this pull request and generated 5 comments.

Copilot · 2026-02-13T23:32:28Z

src/frontend/vite.config.ts

+    let lastUpdated = ''
+    try {
+      // Use git log to get the last commit date
+      lastUpdated = execSync(`git log -1 --format=%cd --date=iso-strict "${filePath}"`).toString().trim()


The execSync call uses string interpolation to embed filePath directly into a shell command without sanitization. Although filePath is derived from fs.readdirSync, a malicious filename (e.g., "; rm -rf / #.md) in the static/ directory could lead to command injection. Use execFileSync instead of execSync to pass arguments safely, or validate that filenames contain only expected characters before running the command.

Copilot · 2026-02-13T23:32:29Z

src/frontend/static/privacy.md

+
+* **Access:** Request a copy of the data we hold about you (Discord ID and linked Wallet), you can review this information in the service homepage (`/home`).
+* **Rectification:** Update your data (typically done by re-syncing your Discord profile).
+* **Erasure ("Right to be Forgotten"):** You may unlink your wallet and request deletion of your account. We support "soft-deletes" and unlinking capabilities.


The privacy policy states "We support 'soft-deletes' and unlinking capabilities" (line 56), but the actual implementation in delete_me performs hard deletion of wallets (DELETE FROM wallets WHERE user_id = ?) and anonymizes the user row rather than soft-deleting. Update this statement to accurately reflect the implementation, e.g., "You may delete your account, which will permanently remove your wallets and anonymize your user profile."

Suggested change

* **Erasure ("Right to be Forgotten"):** You may unlink your wallet and request deletion of your account. We support "soft-deletes" and unlinking capabilities.

* **Erasure ("Right to be Forgotten"):** You may delete your account, which will permanently remove your wallets and anonymize your user profile. You may also unlink your wallet without deleting your account.

Copilot · 2026-02-13T23:32:29Z

src/frontend/src/routes/home.lazy.tsx

+                        setIsDeleteModalOpen(false);
+                    } catch (err) {
+                        console.error('Failed to delete account:', err);


If deleteAccount() throws an error (network failure, non-200 response, etc.), the modal is left open because setIsDeleteModalOpen(false) is only called on success. The error message is logged to console and set via setError, but the user is stuck in the modal with no clear recovery path. Consider calling setIsDeleteModalOpen(false) in a finally block, or adding UI feedback (e.g., displaying the error inside the modal) to improve the user experience.

Suggested change

setIsDeleteModalOpen(false);

} catch (err) {

console.error('Failed to delete account:', err);

} catch (err) {

console.error('Failed to delete account:', err);

alert('Failed to delete your profile. Please try again in a moment, or contact support if the problem persists.');

} finally {

setIsDeleteModalOpen(false);

Copilot · 2026-02-13T23:32:29Z

src/frontend/src/routes/deleted.tsx

+              Your account has been permanently deleted at your request to fulfill your <a href="https://ico.org.uk/for-organisations/uk-gdpr-guidance-and-resources/individual-rights/individual-rights/right-to-erasure/" style={{ color: '#ef4444', textDecoration: 'underline', textUnderlineOffset: '4px', transition: 'opacity 0.2s' }} onMouseOver={(e) => e.currentTarget.style.opacity = '0.8'} onMouseOut={(e) => e.currentTarget.style.opacity = '1'}><strong>Right to be Forgotten / Right to erasure</strong></a> under GDPR.
+            </p>
+            <p>
+              As part of our commitment to your privacy, your Discord ID and associated Wallet Addresses have been completely delisted and barred from future use to ensure that this data cannot be re-processed or used to recreate a profile on this platform.


Inconsistent terminology: the deleted page uses "delisted" (line 49), but the rest of the codebase uses "denylisted" (e.g., identity_hashes table, error messages like "This wallet has been denylisted due to account deletion"). For consistency and clarity, consider updating "delisted" to "denylisted" or use a more user-friendly term like "blocked" that aligns with the inclusive language goals of this PR.

Suggested change

As part of our commitment to your privacy, your Discord ID and associated Wallet Addresses have been completely delisted and barred from future use to ensure that this data cannot be re-processed or used to recreate a profile on this platform.

As part of our commitment to your privacy, your Discord ID and associated Wallet Addresses have been permanently blocked from future use to ensure that this data cannot be re-processed or used to recreate a profile on this platform.

Copilot · 2026-02-13T23:32:29Z

src/backend/src/state.rs

+        let identity_hash_pepper = std::env::var("IDENTITY_HASH_PEPPER")
+            .expect("IDENTITY_HASH_PEPPER must be set for security and deterministic hashing");


The new required environment variable IDENTITY_HASH_PEPPER is not documented in .env.example. Since state.rs uses .expect() to require this variable at startup, developers will experience cryptic errors if they don't set it. Add an entry to .env.example with a comment explaining its purpose (e.g., "Secret pepper for hashing denylisted identifiers. Generate a strong random string.") to guide developers and ensure smooth setup.

Scetrov added 7 commits February 12, 2026 22:51

fat: compliance docs

960e7ee

Merge main into branch and resolve conflicts

667cef8

fix: update wording

a2700fd

feat: delete profile

85b21de

fix: upgrade to modal

0e25927

feat: completion of delete feature

c5dc35d

Scetrov self-assigned this Feb 13, 2026

Scetrov added the dependencies Pull requests that update a dependency file label Feb 13, 2026

Copilot AI review requested due to automatic review settings February 13, 2026 21:31

Copilot started reviewing on behalf of Scetrov February 13, 2026 21:32 View session

Merge remote-tracking branch 'origin/main' into feat/compliance

247137f

This comment was marked as resolved.

Sign in to view

Scetrov added 4 commits February 13, 2026 22:04

Merge remote-tracking branch 'origin/main' into feat/compliance

5a0d925

fix: address review comment on privacy.md regarding typo

17dafd9

fix: address review comment on vite.config.ts regarding __dirname

6ba56d8

perf: address review comment on .tsx by lazy loading markdown depende…

8a8cb5e

…ncies

Copilot AI review requested due to automatic review settings February 13, 2026 22:09

Copilot started reviewing on behalf of Scetrov February 13, 2026 22:10 View session

This comment was marked as resolved.

Sign in to view

Scetrov added 4 commits February 13, 2026 22:36

fix: address review comment on main.rs regarding missing discord_logi…

f1bc504

…n in OpenAPI paths

fix: address review comment on ConfirmationModal.tsx regarding design…

a258e24

…-system mismatch

fix: address review comment on cookies.md regarding auth token storage

9456028

fix: address second round of review comments on PR #19

5730d5e

Copilot AI review requested due to automatic review settings February 13, 2026 22:45

Copilot started reviewing on behalf of Scetrov February 13, 2026 22:45 View session

This comment was marked as resolved.

Sign in to view

fix: address remaining PR comments

e1a0f1d

Scetrov enabled auto-merge (squash) February 13, 2026 23:11

Scetrov disabled auto-merge February 13, 2026 23:13

fix: playwright in CI

0d8843f

Copilot AI review requested due to automatic review settings February 13, 2026 23:24

Copilot started reviewing on behalf of Scetrov February 13, 2026 23:24 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compliance#19

Compliance#19
Scetrov wants to merge 18 commits intomainfrom
feat/compliance

Scetrov commented Feb 13, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Scetrov commented Feb 13, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	* Erasure ("Right to be Forgotten"): You may unlink your wallet and request deletion of your account. We support "soft-deletes" and unlinking capabilities.
	* Erasure ("Right to be Forgotten"): You may delete your account, which will permanently remove your wallets and anonymize your user profile. You may also unlink your wallet without deleting your account.

	As part of our commitment to your privacy, your Discord ID and associated Wallet Addresses have been completely delisted and barred from future use to ensure that this data cannot be re-processed or used to recreate a profile on this platform.
	As part of our commitment to your privacy, your Discord ID and associated Wallet Addresses have been permanently blocked from future use to ensure that this data cannot be re-processed or used to recreate a profile on this platform.

		let identity_hash_pepper = std::env::var("IDENTITY_HASH_PEPPER")
		.expect("IDENTITY_HASH_PEPPER must be set for security and deterministic hashing");

Conversation

Scetrov commented Feb 13, 2026

1. Title

2. Description

What?

Why?

How?

3. Type of Change

4. Development Checklist

5. Security Assessment

6. Frontend (if applicable)

7. Reviewer Feedback & Resolution

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Scetrov commented Feb 13, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant