You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just wondering, why add if (Line.Contains("%map%") || Line.Contains("%players%"))? You check that in parseLine anyway.
Also, why iterate through each word? instead of just Line.Replace("%map%", worldName);. Is it so the variable has to be it's own word? That kinda defeats the point of using obscure symbols to reference a variable. If someone misses a space, it will just show e.g. Map name:%map%.
I added
if (Line.Contains("%map%") || Line.Contains("%players%"))
Because that way it only checks lines that contains those, rather checking every line.
I iterated through every word because previous testing with Line.Replace("string", "newstring") failed. Although you made me realise there was a MUCH simpler way of doing it. Do you want me to bother with Line.Contains() in the broadcast method? Or would you prefer me to remove it from there and just leave it in parseLine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like MotD, replaces "%map%" with the world name or TShock server nickname, and "%players%" with a list of currently online players.