Duplicate modl and mesh entries #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The automated checks are failing. Make sure your code is formatted correctly and all the tests pass. Once the comments are addressed and the checks pass, this should be good to merge. |
zrksyd
force-pushed
the
main
branch
3 times, most recently
from
5ddc34f to
89eda26
Compare
Contributor
Author
|
Automated checks and all the suggestions have been dealt with. |
Contributor
Author
|
Wait should Duplicate be above or below Delete? |
Owner
|
It shouldn't matter in the code unless someone finds a way to click two buttons in one frame. For the ordering in the menu itself, just try and match existing menu ordering if possible. |
zrksyd
force-pushed
the
main
branch
2 times, most recently
from
2cc5c9d to
4dcc66b
Compare
Owner
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to rename modl entries but I still think this is useful.