Skip to content

Duplicated CI job runs on pull requests?#3866

Open
backmari wants to merge 3 commits intomainfrom
backmari_duplicated_ci_jobs
Open

Duplicated CI job runs on pull requests?#3866
backmari wants to merge 3 commits intomainfrom
backmari_duplicated_ci_jobs

Conversation

@backmari
Copy link
Contributor

@backmari backmari commented Feb 10, 2026

Description

All pull request CI jobs are run twice, since the triggers are both push and pull_request for any branch. This change reduces the number of jobs run by half. The jobs will still be re-triggered if new commits are pushed.

This change would, however, mean that one has to create a pull request to trigger the CI pipeline, or use the workflow dispatch functionality:

image

https://github.com/SasView/sasview/actions/workflows/ci.yml

Fixes # (issue/issues)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@backmari backmari marked this pull request as ready for review February 10, 2026 20:51
@llimeht
Copy link
Contributor

llimeht commented Feb 12, 2026

Being able to run CI in forks and on branches that don't have a PR is needed; adding developer documentation about how to do so from the GUI and with the gh command-line tool is needed, as most projects do not disable this and new developers will reasonably expect that CI runs on their work and they can test things out prior to making a PR.

(From memory it's something like gh workflow run --repo <org>/<repo> --ref <branch> ci.yml, so gh workflow run --repo llimeht/sasview --ref tmp/some-work-in-progress-branch ci.yml )

@backmari
Copy link
Contributor Author

Is this an acceptable compromise? That is, we provide developer documentation on how to trigger CI on a branch, but the CI no longer runs automatically on branches, only on PR:s?
We need to trigger on PR:s since otherwise the CI won't run on PR:s from forks.
@krzywon @DrPaulSharp Any opinions? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants