You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All pull request CI jobs are run twice, since the triggers are both push and pull_request for any branch. This change reduces the number of jobs run by half. The jobs will still be re-triggered if new commits are pushed.
This change would, however, mean that one has to create a pull request to trigger the CI pipeline, or use the workflow dispatch functionality:
Being able to run CI in forks and on branches that don't have a PR is needed; adding developer documentation about how to do so from the GUI and with the gh command-line tool is needed, as most projects do not disable this and new developers will reasonably expect that CI runs on their work and they can test things out prior to making a PR.
(From memory it's something like gh workflow run --repo <org>/<repo> --ref <branch> ci.yml, so gh workflow run --repo llimeht/sasview --ref tmp/some-work-in-progress-branch ci.yml )
Is this an acceptable compromise? That is, we provide developer documentation on how to trigger CI on a branch, but the CI no longer runs automatically on branches, only on PR:s?
We need to trigger on PR:s since otherwise the CI won't run on PR:s from forks. @krzywon@DrPaulSharp Any opinions? 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All pull request CI jobs are run twice, since the triggers are both
pushandpull_requestfor any branch. This change reduces the number of jobs run by half. The jobs will still be re-triggered if new commits are pushed.This change would, however, mean that one has to create a pull request to trigger the CI pipeline, or use the workflow dispatch functionality:
https://github.com/SasView/sasview/actions/workflows/ci.yml
Fixes # (issue/issues)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)