[MAINT] Use GuiUtil.communicator wherever possible#3863
[MAINT] Use GuiUtil.communicator wherever possible#3863
GuiUtil.communicator wherever possible#3863Conversation
…municator to ensure every widget is calling the same communicator object to ensure all signals are passed through a central object
|
I always found the noun vs verb in communicator vs communicate quite confusing in this code base. That might not be worth addressing at all, of course. It probably is worth doing something with the tests, although since they got disabled a few years ago the bit rot will be terrible. That said, this is the sort of change that is likely to help them greatly by fixing cross-thread calls that Qt does not support and so led to segfaults in them. |
|
I switched the base import to |
GuiUtil.communicate wherever possibleGuiUtil.communicator wherever possible
Description
This ensures all cross widget signals are directed through the same signal handler. This prevents orphaned signals and cleans up the interface for generating signals. I am not 100% sure I found all communicator objects, but found many.
How Has This Been Tested?
This needs more testing, especially in places where
self.<parent|manager>.<communicate|communicator>are being replaced.Review Checklist:
Documentation (check at least one)
Installers
Licensing (untick if necessary)