Skip to content

point to the correct logic#3843

Open
rozyczko wants to merge 1 commit intorelease-6.1.3from
3783-polydispersity-fitting-not-available-in-batch-fitting
Open

point to the correct logic#3843
rozyczko wants to merge 1 commit intorelease-6.1.3from
3783-polydispersity-fitting-not-available-in-batch-fitting

Conversation

@rozyczko
Copy link
Member

Description

Fitting widget refactor caused yet another issue. Addressed.

Fixes #3783

How Has This Been Tested?

Local Win10 tests

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this corrects the issue and the code looks fine. I'll wait to merge this in case others want time to take a look.

@krzywon
Copy link
Contributor

krzywon commented Jan 23, 2026

The failing CIs are not using the release requirements files, which is the cause of the failure. As long as the pull request CIs are successful, this can be merged.

@krzywon
Copy link
Contributor

krzywon commented Feb 2, 2026

@gnsmith has agreed to review the functionality of this PR, but that review will likely have to wait a couple of weeks. This will likely be the last PR before a final release candidate for v6.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants