Support angularly replicated 'symmetric' slicers#3832
Support angularly replicated 'symmetric' slicers#3832jellybean2004 wants to merge 15 commits intomainfrom
Conversation
|
I have played around with this on my macbook. The symmetric slicers seem to be working as intended, nice work! Notes: Comments: Also, do we want to make a warning window every time someone wants to make more than a few slicers? It could be annoying to always be clicking "ok" whenever I want to make a symmetric set of slicers. Maybe it is better to just have a little warning in the "Slice Parameters" GUI that adding more than 4 slicers could be slow. Future Work: |
|
@smk78, I added docs for the wedge slicers as well as screenshots for each slicer as you stated in your issue. Please let me know if this is all okay. |
Would it be faster if, above a certain number of slicers, you can only update via the GUI interface? i.e., is the major slowdown happening in the interactive plot elements, the rendering, or the calculations? If it is the interactive plot elements slowing things down, a GUI-only control may be better. |
Read the documentation generated by CI build #5326 . Looks good to me. |
ffcbebf to
f3da2ec
Compare
|
Properly rebased to main, removing duplicate commits from the merged parent branch. |
DrPaulSharp
left a comment
There was a problem hiding this comment.
I've a few suggestions on the code here, I'll leave the functionality testing to @butlerpd as discussed.
f3da2ec to
0c610f5
Compare
JoGaudet
left a comment
There was a problem hiding this comment.
I have tested the symmetric slicer option on a PC. The features seem to work as intended for both wedges and sector cuts. I have two suggestions:
-
I believe one should have the option to fold the data or not.
-
Incorporating Box interactors would be very useful. For this, one would build symmetric box interactors with various X and Y interactors. One would need to constraint each Box interactors to (qx,qy)=(0,0) in this case. Does that sound reasonable?
Description
This PR introduces symmetry-linked wedge and sector slicers for 2D data.
Users can now specify a number of slicers (N), which are automatically generated as congruent slicers, evenly distributed in angle around the plot centre. One of these will be the 'master' slicer, which is the only directly modifiable slicer, and the others will change automatically based on this.
This also adds the documentation for #3758 and #3806
Fixes #3807 #3794 #3802
To add symmetric slicers:
Slicers>Slicer ParametersSymmetric Slicersat the bottom of the first tabManually tested functionality using 2D data. Verified:
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)