Keep the tabbed plot widget inside the main window#3761
Draft
backmari wants to merge 1 commit intoplotting_refactor_integrationfrom
Draft
Keep the tabbed plot widget inside the main window#3761backmari wants to merge 1 commit intoplotting_refactor_integrationfrom
backmari wants to merge 1 commit intoplotting_refactor_integrationfrom
Conversation
… GUI and make it minimize on close
krzywon
approved these changes
Nov 14, 2025
Contributor
krzywon
left a comment
There was a problem hiding this comment.
Code looks good. Haven't tested the functionality.
Contributor
|
I am not sure what it's the status of this, so sorry if I miss something. Testing the functionality on a Windows 11 laptop:
As these are the 2 things that this PR is supposed to do, I would say that it can be merged.
|
Contributor
Author
|
@gonzalezma Thank you very much for testing!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small changes:
Minimizing rather than closing is a workaround for the tabbed plot widget getting into a weird state and not showing any plots after having been closed once. I think it is still something to discuss what the correct behavior should be. There is currently not a way to completely delete a plot from the tabbed plot widget, like how you can close and delete the existing floating plot windows. We may also want to keep the plot widget around permanently, like e.g. the data explorer.
Fixes # (issue/issues)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)