Conversation
8 tasks
llimeht
approved these changes
Oct 19, 2025
Contributor
llimeht
left a comment
There was a problem hiding this comment.
Some comments on minor improvements but looks good. Thanks!
Contributor
|
Thanks @klytje! Two remaining things:
We should have some Windows and Mac users check that the library is working fine in the installers on those platforms, but if there are issues there, perhaps they just get reported and addressed in subsequent improvement cycles rather than holding up this PR. |
… all files related to the old approach
Contributor
Author
Member
Contributor
Author
|
@butlerpd Yes I closed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #3559 and #3554, this PR replaces the current direct
AUSAXSshared library integration with calls to the newpyAUSAXSwrapper I designed specifically for this integration.Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
We should verify that the
pyAUSAXSlibrary correctly installs on real systems beyond the GitHub runners. Someone who's more competent than me at building Python wheels should also verify that the three wheels available from pypi are general enough to be installable on all relevant systems.I have removed the
c60.pdbsystem from Debye testing and relaxed the tolerance to 3% on the remaining systems. Previously, I was compiling higher-precision customAUSAXSversions for SasView, butpyAUSAXSuses the default, lower-precision release, which was failing these tests.Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)