Sasview counterpart to sasdata manipulations rewrite#2615
Sasview counterpart to sasdata manipulations rewrite#2615ehewins wants to merge 17 commits intorelease_6.0.0from
Conversation
…t, and changed variable names to new versions. Also removed the angle transformation, as new_manipulations uses the same -pi to pi interval as the slicers.
…o-sasdata-manipulations-rewrite
lucas-wilkins
left a comment
There was a problem hiding this comment.
Should be fine if the sasdata bit is
|
Everything here looks fine, but I have a few suggestions.
|
|
Hi @wpotrzebowski , apologies about the lack of activity recently. I wish I could, but university work has completely taken over my life at the moment. I had wanted to do some more work on my unit test file in the other repo, and was up for doing this too, but I don't think I'll have time until several weeks from now. |
|
@krzywon will take a quick look at it |
|
I have a commit to push here, but want to be sure the changes I made in SasView/sasdata#47 are acceptable, so I don't pollute two different PRs. The changes have to do with the file name change (from |
lucas-wilkins
left a comment
There was a problem hiding this comment.
Needs to be updated to refer to averaging, not new_manipulations
…of new_manipulations
…terpart-to-sasdata-manipulations-rewrite
|
This PR and the associated one, SasView/sasdata#47, are ready for a full review. The CI for this PR points to the associated sasdata branch and should be changed prior to merging. |
…pulations-rewrite
|
Using the requirements specified by this branch (following the setup guide) results in a problem for matplotlib 3.5.3 (matplotlib/matplotlib#24374) Can be fixed by following the solution there (installing matplotlib 3.6.2). Assuming I followed the correct install procedure it may be necessary to update build_tools/requirements.txt to have Note, this is not a problem for the built installer as it uses the appropriate version |
|
Closing because too out of sync, not deleting branch though |
Description
This pull request, as the title suggests, is the sasview counterpart to my rewrite of sasdata's
manipulations.py. Full details are given in this pull request.Fixes #2593
Review Checklist (please remove items if they don't apply):