[WIP] Servers implementation #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding end to end tests for chat.react endpoint
…oint [FIX] Chat Message Reactions REST API End Point
[NEW] Global message search (beta: disabled by default)
maabed
commented
Mar 7, 2018
| admin: String | ||
| userIds: [String] | ||
| invitedEmails: [String] | ||
| avatarUrl: String |
Author
There was a problem hiding this comment.
@rgio check this model if you think we need to add more fields here
rgio
requested changes
Apr 5, 2018
Collaborator
There was a problem hiding this comment.
When creating a public channel, clicking join in the preview window doesn't do anything (The channel is created but i have to reload in order to see it)
Clicking on own name in direct messages shows no user with username found.
Channel names should be unique to servers rather than to the entire application. Trying to create a channel with an existing name in a different server results in this error.
Directory should only show users in the selected server.
Replace sort option with user status(online, away, offline) move my account from server tab to here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task
The idea is to have the same feature on discordapp.com where we can have servers that control all content's (channels, DM's, users, files ...etc) inside it, every server contents will be separated from other servers and the user can join multi-servers.
This PR will take care of implementing servers functionality as a standalone app, will take care of integrating RC into Sepian app on next PR.
TODO:
/serverId/channelId.