Skip to content

(test) Added tests for checking configuration, checking results. Added basic fixures in conftest.#14

Open
Zim95 wants to merge 3 commits intoSafe-Security:mainfrom
Zim95:zim95_tests_testlogger
Open

(test) Added tests for checking configuration, checking results. Added basic fixures in conftest.#14
Zim95 wants to merge 3 commits intoSafe-Security:mainfrom
Zim95:zim95_tests_testlogger

Conversation

@Zim95
Copy link

@Zim95 Zim95 commented Oct 26, 2022

There are two types of tests that were added:

  1. Configuration Tests: These tests verify that the logger's configurations are correctly set.
  2. Testing Results of various operations: These tests are assert statements between the input and the result of operations. We use @pytest.mark.parameterize, for these tests.

@Zim95 Zim95 force-pushed the zim95_tests_testlogger branch from 897bfcb to b04814e Compare October 26, 2022 18:15
@Zim95 Zim95 mentioned this pull request Oct 27, 2022
@aneeshrelan
Copy link
Contributor

Thanks for your contribution @Zim95. I’ll take a look at this in a day or two

@Zim95
Copy link
Author

Zim95 commented Oct 27, 2022

Thanks for your contribution @Zim95. I’ll take a look at this in a day or two

Thanks @aneeshrelan .

@deepak-sreekumar
Copy link
Contributor

Thanks for the PR @Zim95. Awesome work! (Loved the detailed test descriptions)

@deepak-sreekumar
Copy link
Contributor

deepak-sreekumar commented Oct 31, 2022

@Zim95 Tests ran fine in my local but the workflow run seems to be failing. Please take a look if you get a chance. (I'll also try to check tomorrow. )

@Zim95
Copy link
Author

Zim95 commented Nov 2, 2022

@Zim95 Tests ran fine in my local but the workflow run seems to be failing. Please take a look if you get a chance. (I'll also try to check tomorrow. )

Hey thanks for letting me know. Glad you like the tests. I will look into it and push again.

@Zim95
Copy link
Author

Zim95 commented Nov 9, 2022

Hi, I have made a simple change. I had to change all occurrences of set[str] to set only. Was getting not subscriptable error. Have removed the changes. Can you run it once more and let me know if it works?

Here is the commit id: e89c449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments