Using bool for mask and handling possible spaces in prediction#4
Open
9173860 wants to merge 1 commit intoSVAIGBA:masterfrom
Open
Using bool for mask and handling possible spaces in prediction#49173860 wants to merge 1 commit intoSVAIGBA:masterfrom
9173860 wants to merge 1 commit intoSVAIGBA:masterfrom
Conversation
alukanlp
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your text file is provided with space char, the length of
labellistwon't be equal totextlistinconvert_examples_to_features.Here comes a quick and dirty fix that replaced all continuous space char into two space char to avoid length change due to split with space char itself.
Also, this MR changed all byte mask to bool mask to eliminate warnings about it.