Conversation
imonroe
left a comment
There was a problem hiding this comment.
Ok, so there's nothing wrong with these changes, but this is going to be the wrong repo for them.
Note that this repo hasn't had a new tag since May of 2022. At that point, we move the theme into the profile. See also: https://github.com/SU-SOE/soe_profile/tree/11.x/themes/soe_basic
You'll see in the soe_profile repo, we no longer call for this dependency in the composer.json file, in lieu of the one in the profile already.
Would you mind moving this to the soe_profile repo, within the themes/soe_basic directory? Otherwise, it'll never get deployed.
In other news, when Mike gets back from vacation, let's have a conversation about archiving this repo or something, just to avoid confusion.
Ah! That makes so much more sense, especially for the reasoning behind why past Rebecca originally opened it up in the soe_profile repo. 😄 I reopened the old PR here: SU-SOE/soe_profile#319 Thanks @imonroe ! |
READY FOR REVIEW
Summary
Review By (Date)
Review Tasks
Setup tasks and/or behavior to test
Check out this branch
Rebuild Cache and import config
drush cr ; drush ciNavigate to site preview
Verify that the footer links have red arrows by default; black arrows on hocus:

Review code
Associated Issues and/or People