Skip to content

chore: migrate sass and update vite#330

Open
jboix wants to merge 1 commit intomainfrom
chore/scss-migration
Open

chore: migrate sass and update vite#330
jboix wants to merge 1 commit intomainfrom
chore/scss-migration

Conversation

@jboix
Copy link
Member

@jboix jboix commented Aug 5, 2025

Description

Prepares the codebase for Dart Sass 3.0 and updates related dependencies.

Changes made

  • Migrated Sass from @import to @use/@forward syntax to prepare for Dart Sass 3.0 using the sass-migrator
  • Upgraded Vite to latest v7+ version to support updated build tools and syntax.
  • Updated all related stylelint dependencies.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.91% 845/863
🟢 Branches 92.52% 396/428
🟢 Functions 98.7% 228/231
🟢 Lines 98.28% 801/815

Test suite run success

249 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 7ba1cbd

@jboix jboix force-pushed the chore/scss-migration branch from 1142400 to 7183959 Compare August 5, 2025 15:00
@jboix jboix moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Aug 5, 2025
@jboix jboix force-pushed the chore/scss-migration branch from 7183959 to 5eb9b77 Compare August 12, 2025 14:15
- Migrated Sass from `@import` to `@use/@forward` syntax to prepare for Dart Sass 3.0 using the
  [`sass-migrator`](https://sass-lang.com/documentation/cli/migrator/)
- Upgraded Vite to latest v7+ version to support updated build tools and syntax.
- Updated all related stylelint dependencies.
@jboix jboix force-pushed the chore/scss-migration branch from 5eb9b77 to 7ba1cbd Compare August 13, 2025 12:41
@github-actions
Copy link

PR Preview Action v1.6.2

🚀 View preview at
https://SRGSSR.github.io/pillarbox-web/pr-preview/pr-330/

Built to branch gh-pages at 2025-08-13 12:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@jboix jboix marked this pull request as ready for review August 19, 2025 12:20
@jboix jboix requested a review from amtins August 19, 2025 12:20
@jboix jboix moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Aug 19, 2025
@amtins
Copy link
Member

amtins commented Aug 22, 2025

After discussion, we decided to leave this PR on hold, it can be merged in a few years if needed.

The reason is that the Sass features used in this project remain very basic.

Refer to: sass/sass#3513 (comment)

@amtins amtins added the On hold PR that will eventually be merged one day. label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On hold PR that will eventually be merged one day.

Projects

Status: 🍿 Code Review

Development

Successfully merging this pull request may close these issues.

2 participants