feat(srg-analytics): remove Pillarbox dependency#306
Draft
Conversation
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success248 tests passing in 10 suites. Report generated by 🧪jest coverage report action from 9b573b4 |
Eliminates dependency on Pillarbox and therefore relies solely on the media element for data collection. It also facilitates the use of any other type of web player. - SRGAnalytics - replace Pillarbox references with media element - add functions to handle live streams - update unit tests - SrgSsr - add function set the playback data - add loadstart handler to update the playback data - adapt unit tests
amtins
force-pushed
the
feat/srg-analytics-remove-pillarbox-dependency
branch
from
e10d452 to
9b573b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eliminates dependency on Pillarbox and therefore relies solely on the media element for data collection. It also facilitates the use of any other type of web player.
Changes made