-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor homepage_deploy to GitOps with OnePasswordItem CRDs and sync-wave ordering #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
…-wave ordering Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
…ail_msg Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot explain this "{{ }}" syntax here, because I don't think that will actually work in cluster. Is there not a way to map this correctly to the onepassword CRD that we've created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct - the {{HOMEPAGE_VAR_ARGOCD_TOKEN}} syntax won't work in a static Kubernetes Ingress manifest. Ingress annotations expect literal string values and don't support variable interpolation.
The issue: We can't put secrets directly in ingress annotations, and Kubernetes doesn't evaluate the {{}} syntax.
The fix (commit 746a102):
- Removed widget configuration from the ingress annotations (widget.type, widget.url, widget.key)
- Added ArgoCD widget to Homepage's main config in the Helm values where it properly interpolates environment variables
- The ingress now only provides basic service discovery metadata (name, description, group, icon)
The correct pattern for widgets requiring secrets:
- Ingress annotations: Service discovery only (no secrets)
- Homepage config: Widget configuration with
{{HOMEPAGE_VAR_*}}references to environment variables that pull from Kubernetes secrets
… handle secrets Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
Co-authored-by: SRF-Audio <16975040+SRF-Audio@users.noreply.github.com>
Plan: Standardize GitOps handoff for homepage_deploy
Implementation Complete ✅
All acceptance criteria met:
Latest Fix (commit 746a102)
Moved ArgoCD widget configuration from ingress annotations to Homepage's main config. Ingress annotations don't support variable interpolation - they expect literal values. The proper pattern is:
{{HOMEPAGE_VAR_ARGOCD_TOKEN}})Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.