fix: [OpenAPI] Introduce openapi-core-apache module
#1083
+931
−303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Member
Author
|
What consequence does this additional module for the sake of spring optionality have ? Surely, the import namespace will be affected. Apart from that the bigger concern is new duplicated classes.
|
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
There are still changes in openapi-core and openapi-generator compared to before your first Apache PR. Ideally there are no changes
newtork
reviewed
Jan 28, 2026
| */ | ||
|
|
||
| package com.sap.cloud.sdk.services.openapi.apache; | ||
| package com.sap.cloud.sdk.services.openapi.apache.apiclient; |
Contributor
There was a problem hiding this comment.
(Question/Major)
This is a breaking change for users that may have depended on the new classes, right?
Is this an accepted risk?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog##464
Fix scope:
openapi-api-apache-sampleDefinition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated